| WIP: Bug 1913666 - Part 13: Wire WindowGlobal IPC trip for fullscreen enter/exit r=edgar!,#dom-core!
Authored by sfarre on May 18 2026, 10:14 PM. Referenced Files | Unknown Object (File) | | Mon, Jun 1, 12:27 PM2026-06-01 12:27:05 (UTC+0) |
| Unknown Object (File) | | Mon, Jun 1, 12:33 AM2026-06-01 00:33:36 (UTC+0) |
| Unknown Object (File) | | Sun, May 31, 8:49 PM2026-05-31 20:49:55 (UTC+0) |
| Unknown Object (File) | | Thu, May 28, 10:26 PM2026-05-28 22:26:04 (UTC+0) |
| Unknown Object (File) | | Wed, May 27, 1:16 AM2026-05-27 01:16:36 (UTC+0) |
| Unknown Object (File) | | Mon, May 25, 5:36 PM2026-05-25 17:36:14 (UTC+0) |
| Unknown Object (File) | | Sat, May 23, 11:13 PM2026-05-23 23:13:41 (UTC+0) |
- Reviewers
- None
- Bugzilla Bug ID
- 1913666
Summary Three PWindowGlobal IPC messages introduced:
- RequestFullscreen - maps to element.requestFullscreen() and queuing a fullscreen request/transaction with the Fullscreen Service
- RequestExitFullscreen - maps to document.exitFullscreen() and queuing an exit of fullscreen request/transaction wiith the Fullscreen service
- FullscreenServiceTransactionComplete - The IPC message a request uses to complete a transaction with the fullscreen service, which informs the fullscreen service of the final result of the request and then allows for next Fullsreen API operation to start (if any is queued).
This transactional model, is what synchronizes access to fullscreen operations. Elements can still be removed mid-flight of one of these operations, and the behavior is best-effort and exiting if some unexpected result happens. Event TimelineComment ActionsCode analysis found 1 defect in diff 1277263:
- 1 defect found by clang-format (Mozlint)
WARNING: Found 1 defect (warning level) that can be dismissed.
You can run this analysis locally with:
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 1277263. | Path | Size |
|---|
| | | 17 lines | | 55 lines | | 33 lines | | 146 lines | | | 37 lines | | 11 lines | | 11 lines | | 33 lines |
| Commit | Tree | Parents | Author | Summary | Date |
|---|
| a913abef564c | d9fdf4980611 | 236d3eab96c7 | Simon Farre | WIP: Bug 1913666 - Part 13: Wire WindowGlobal IPC trip for fullscreen… (Show More…) | May 18 2026, 8:06 PM |
- Wed, Jun 17, 11:33 PM2026-06-17 23:33:26 (UTC+0)
- Wed, Jun 17, 11:11 PM2026-06-17 23:11:41 (UTC+0)
- Wed, Jun 17, 5:35 PM2026-06-17 17:35:12 (UTC+0)
- Wed, Jun 17, 4:11 PM2026-06-17 16:11:00 (UTC+0)
- Wed, Jun 17, 3:41 PM2026-06-17 15:41:56 (UTC+0)
- Wed, Jun 17, 3:26 PM2026-06-17 15:26:30 (UTC+0)
- Tue, Jun 16, 8:11 PM2026-06-16 20:11:54 (UTC+0)
- Tue, Jun 16, 4:45 PM2026-06-16 16:45:44 (UTC+0)
- Tue, Jun 16, 10:52 AM2026-06-16 10:52:01 (UTC+0)
- Fri, Jun 12, 9:18 PM2026-06-12 21:18:56 (UTC+0)
dom/base/FullscreenService.hdom/base/FullscreenService.cppdom/ipc/PWindowGlobal.ipdldom/ipc/WindowGlobalChild.hdom/ipc/WindowGlobalParent.hdom/ipc/WindowGlobalParent.cpp |
