Differential D302134 Authored by Dre on Fri, May 22, 7:19 PM. Tags None Referenced Files
Details Summary Lands the Nova-only Games widget infrastructure without any actual games What ships in this shell:
Out of scope (follow-up commits, one per game): the 10 game modules
Diff Detail
Event TimelineDre planned changes to this revision.Fri, May 22, 7:19 PM Dre created this revision. phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Fri, May 22, 7:20 PM phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Dre requested review of this revision.Thu, May 28, 12:51 AM Dre updated this revision to Diff 1284930. Dre retitled this revision from WIP: Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers to Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers. Dre edited the summary of this revision. (Show Details) Dre added a reviewer: home-newtab-reviewers-rotation. phab-bot removed reviewers: home-newtab-reviewers-rotation, reusable-components-reviewers-rotation. Dre planned changes to this revision.Thu, May 28, 12:54 AM Dre removed reviewers: accessibility-frontend-reviewers, reemhamz, akulyk. Dre planned changes to this revision.Thu, May 28, 1:50 AM Dre updated this revision to Diff 1284975. Dre retitled this revision from Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers to WIP: Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers. Dre requested review of this revision.Thu, May 28, 9:31 PM Dre updated this revision to Diff 1286072. Dre retitled this revision from WIP: Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers to Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers. Dre planned changes to this revision.Thu, May 28, 9:33 PM Comment Actions Based on slack conversation, this is a POC and no current plan for a release. We shouldn't expose these strings to localization, so should take them out of the path and put them somewhere like . Dre retitled this revision from Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers.Thu, Jun 4, 4:16 PM Dre removed reviewers: Restricted Project, desktop-theme-reviewers. Dre requested review of this revision.Tue, Jun 16, 6:39 PM Dre updated this revision to Diff 1301563. Dre retitled this revision from Proof of concept, not for merging - Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers to Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers. Dre added a reviewer: home-newtab-reviewers-rotation. Comment Actions This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels. If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed. If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing. phab-bot removed a reviewer: home-newtab-reviewers-rotation. Dre planned changes to this revision.Tue, Jun 16, 6:42 PM Dre retitled this revision from Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add Games widget shell r?#home-newtab-reviewers.
Revision Contents
Diff 1301563 browser/extensions/newtab/content-src/components/CustomizeMenu/ContentSection/ContentSection.jsxLoading... browser/extensions/newtab/content-src/components/CustomizeMenu/CustomizeMenu.jsxLoading... browser/extensions/newtab/content-src/components/Notifications/Notifications.jsxLoading... browser/extensions/newtab/content-src/components/Notifications/Toasts/GamesSizePromptToast.jsxLoading... browser/extensions/newtab/content-src/components/Notifications/_Notifications.scssLoading... browser/extensions/newtab/content-src/components/Nova/CustomizeMenu/WidgetsManagementPanel/WidgetsManagementPanel.jsxLoading... browser/extensions/newtab/content-src/components/Widgets/Games/GameEndOverlay.jsxLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/index.mjsLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/types.mjsLoading... browser/extensions/newtab/content-src/components/Widgets/WidgetsComponentRegistry.jsxLoading... browser/extensions/newtab/test/jest/content-src/components/Widgets/WidgetsRegistry.test.jsxLoading... browser/extensions/newtab/test/unit/content-src/components/Nova/CustomizeMenu/WidgetsManagementPanel/WidgetsManagementPanel.test.jsxLoading... |
 |
VOOZH | about |