VOOZH about

URL: https://phabricator.services.mozilla.com/D302936

⇱ ⚙ D302936 Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers


Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers
Changes PlannedPublic

Authored by Dre on Thu, May 28, 12:51 AM.
Tags
None
Referenced Files
F72908236: D302936.1781778618.diff
Wed, Jun 17, 10:30 AM
Unknown Object (File)
Sat, Jun 6, 12:18 PM
Unknown Object (File)
Sat, Jun 6, 12:19 AM
Unknown Object (File)
Fri, Jun 5, 8:11 PM
Unknown Object (File)
Fri, Jun 5, 7:08 PM
Unknown Object (File)
Wed, Jun 3, 6:43 AM
Unknown Object (File)
Wed, Jun 3, 2:33 AM
Unknown Object (File)
Wed, Jun 3, 12:34 AM

Details

Reviewers
None
Bugzilla Bug ID
2039394
Summary

Adds the second game to the Games widget: Mozong, a small Pong-style
game played against a CPU opponent. First to 5 points wins. No
persistent high score.

  • Adds Games/titles/Mozong/ with the React component, SCSS, and game-logic module.
  • Registers it in Games/titles/index.mjs.
  • Adds the per-game SCSS @import in _Games.scss.
  • Adds per-game l10n strings (game label, canvas aria-label, win/loss).

Parent: Bug 2039394 Add MozTacToe game.

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Unit TestsBroken

TimeTest
0 mscode-review::general
WARNING: A generic error occurred in the code review bot.

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Dre planned changes to this revision.Thu, May 28, 12:55 AM
Dre removed a reviewer: reemhamz.
Dre retitled this revision from Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers.
Dre planned changes to this revision.Thu, May 28, 1:50 AM
Dre requested review of this revision.Thu, May 28, 9:31 PM
Dre updated this revision to Diff 1286074.
Dre retitled this revision from WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to Bug 2039394 - Add Mozong game r?#home-newtab-reviewers.
bolsson added inline comments.
browser/locales/en-US/browser/newtab/newtab.ftl
703

Question - is this game title name cleared by legal?

bolsson requested changes to this revision.Wed, Jun 3, 10:31 PM
Comment Actions

Based on slack conversation, this is a POC and no current plan for a release. We shouldn't expose these strings to localization, so should take them out of the path and put them somewhere like .

This revision now requires changes to proceed.Wed, Jun 3, 10:31 PM
Dre retitled this revision from Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers.Thu, Jun 4, 4:16 PM
Dre removed reviewers: Restricted Project, desktop-theme-reviewers, bolsson.
This revision now requires review to proceed.Thu, Jun 4, 4:16 PM
Dre planned changes to this revision.Tue, Jun 16, 5:26 PM
Dre retitled this revision from Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers.
Comment Actions

This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels.

If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed.

If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing.

Dre planned changes to this revision.Tue, Jun 16, 8:25 PM
Dre retitled this revision from WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers.Tue, Jun 16, 8:27 PM

Revision Contents

PathSize
browser/
extensions/
newtab/
content-src/
components/
Widgets/
Games/
1 line
titles/
Mozong/
262 lines
70 lines
312 lines
7 lines
css/
66 lines
nova/
66 lines
data/
content/
537 lines
test/
jest/
content-src/
components/
Widgets/
Games/
214 lines
locales/
en-US/
browser/
newtab/
8 lines
CommitTreeParentsAuthorSummaryDate
8adbffb7c73404a98bbf5688de1c2312ef0eDre Grant
WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers (Show More…)
Wed, May 27, 1:51 AM

Diff 1301649

browser/extensions/newtab/content-src/components/Widgets/Games/_Games.scss

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/Mozong/Mozong.jsx

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/Mozong/_Mozong.scss

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/Mozong/mozong.mjs

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/index.mjs

Loading...

browser/extensions/newtab/css/activity-stream.css

Loading...

browser/extensions/newtab/css/nova/activity-stream.css

Loading...

browser/extensions/newtab/data/content/activity-stream.bundle.js

Loading...

browser/extensions/newtab/test/jest/content-src/components/Widgets/Games/Mozong.test.jsx

Loading...

browser/locales/en-US/browser/newtab/newtab.ftl

Loading...