Differential D302936 Authored by Dre on Thu, May 28, 12:51 AM. Tags None Referenced Files
Subscribers
Details
Summary Adds the second game to the Games widget: Mozong, a small Pong-style
Parent: Bug 2039394 Add MozTacToe game.
Diff Detail
Unit TestsBroken
Event TimelineDre created this revision.Thu, May 28, 12:51 AM phab-bot published this revision for review.Thu, May 28, 12:54 AM phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)". phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Herald added 1 blocking reviewer(s): home-newtab-reviewers-rotation. · View Herald TranscriptThu, May 28, 12:54 AM phab-bot removed a reviewer: home-newtab-reviewers-rotation. phab-bot added a subscriber: home-newtab-reviewers-rotation. Dre planned changes to this revision.Thu, May 28, 12:55 AM Dre retitled this revision from Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers. Dre planned changes to this revision.Thu, May 28, 1:50 AM Dre requested review of this revision.Thu, May 28, 9:31 PM Dre updated this revision to Diff 1286074. Dre retitled this revision from WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to Bug 2039394 - Add Mozong game r?#home-newtab-reviewers. bolsson requested changes to this revision.Wed, Jun 3, 10:31 PM Comment ActionsBased on slack conversation, this is a POC and no current plan for a release. We shouldn't expose these strings to localization, so should take them out of the path and put them somewhere like . This revision now requires changes to proceed.Wed, Jun 3, 10:31 PM Dre retitled this revision from Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers.Thu, Jun 4, 4:16 PM Dre removed reviewers: Restricted Project, desktop-theme-reviewers, bolsson. This revision now requires review to proceed.Thu, Jun 4, 4:16 PM Dre planned changes to this revision.Tue, Jun 16, 5:26 PM Dre retitled this revision from Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers. Comment Actions This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels. If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed. If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing. Dre planned changes to this revision.Tue, Jun 16, 8:25 PM Dre retitled this revision from WIP: Bug 2039394 - Add Mozong game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add Mozong game r?#home-newtab-reviewers.Tue, Jun 16, 8:27 PM
Revision Contents
Diff 1301649 browser/extensions/newtab/content-src/components/Widgets/Games/titles/Mozong/Mozong.jsxLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/Mozong/_Mozong.scssLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/Mozong/mozong.mjsLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/index.mjsLoading... browser/extensions/newtab/test/jest/content-src/components/Widgets/Games/Mozong.test.jsxLoading... |
