VOOZH about

URL: https://phabricator.services.mozilla.com/D302137

⇱ ⚙ D302137 Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers


Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers
Changes PlannedPublic

Authored by Dre on Fri, May 22, 7:42 PM.
Tags
None
Referenced Files
F72880216: D302137.1781743932.diff
Wed, Jun 17, 12:52 AM
Unknown Object (File)
Mon, Jun 15, 12:39 PM
Unknown Object (File)
Mon, Jun 15, 12:15 PM
Unknown Object (File)
Mon, Jun 15, 12:14 PM
Unknown Object (File)
Fri, Jun 5, 7:17 AM
Unknown Object (File)
Tue, Jun 2, 11:22 AM
Unknown Object (File)
Tue, Jun 2, 11:20 AM
Unknown Object (File)
Tue, Jun 2, 11:20 AM

Details

Reviewers
None
Bugzilla Bug ID
2039394
Summary

Adds the first game to the Games widget: MozTacToe, a 3x3 tic-tac-toe
against a CPU opponent. No high score.

  • Adds Games/titles/MozTacToe/ with the React component, SCSS, and game-logic module.
  • Registers it in Games/titles/index.mjs (first GAME_REGISTRY entry).
  • Re-introduces the per-game SCSS @import in _Games.scss.
  • Adds per-game l10n strings (game label + win/loss/draw).

Parent: Bug 2039394 Games widget shell.

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Unit TestsBroken

TimeTest
0 mscode-review::general
WARNING: A generic error occurred in the code review bot.

Event Timeline

Dre planned changes to this revision.Fri, May 22, 7:42 PM
Dre created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Fri, May 22, 7:42 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Dre requested review of this revision.Thu, May 28, 12:51 AM
Dre updated this revision to Diff 1284931.
Dre retitled this revision from WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.
Dre planned changes to this revision.Thu, May 28, 1:50 AM
Dre updated this revision to Diff 1284976.
Dre retitled this revision from Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.
Dre requested review of this revision.Thu, May 28, 9:31 PM
Dre updated this revision to Diff 1286073.
Dre retitled this revision from WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.
Dre planned changes to this revision.Thu, May 28, 9:32 PM
Dre retitled this revision from Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.Thu, Jun 4, 4:16 PM
Dre removed reviewers: Restricted Project, desktop-theme-reviewers.
Dre retitled this revision from Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.
Comment Actions

This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels.

If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed.

If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing.

Dre planned changes to this revision.Tue, Jun 16, 8:25 PM
Dre retitled this revision from WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.Tue, Jun 16, 8:27 PM

Revision Contents

PathSize
browser/
extensions/
newtab/
content-src/
components/
Widgets/
Games/
2 lines
titles/
MozTacToe/
109 lines
65 lines
161 lines
11 lines
css/
59 lines
nova/
59 lines
data/
content/
279 lines
test/
jest/
content-src/
components/
Widgets/
Games/
177 lines
locales/
en-US/
browser/
newtab/
5 lines
CommitTreeParentsAuthorSummaryDate
de1c2312ef0eabcf860d2a6a879f88a018ceDre Grant
WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers (Show More…)
Fri, May 22, 7:41 PM

Diff 1301648

browser/extensions/newtab/content-src/components/Widgets/Games/_Games.scss

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/MozTacToe/MozTacToe.jsx

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/MozTacToe/_MozTacToe.scss

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/MozTacToe/moztactoe.mjs

Loading...

browser/extensions/newtab/content-src/components/Widgets/Games/titles/index.mjs

Loading...

browser/extensions/newtab/css/activity-stream.css

Loading...

browser/extensions/newtab/css/nova/activity-stream.css

Loading...

browser/extensions/newtab/data/content/activity-stream.bundle.js

Loading...

browser/extensions/newtab/test/jest/content-src/components/Widgets/Games/MozTacToe.test.jsx

Loading...

browser/locales/en-US/browser/newtab/newtab.ftl

Loading...