Differential D302137 Authored by Dre on Fri, May 22, 7:42 PM. Tags None Referenced Files
Details
Summary Adds the first game to the Games widget: MozTacToe, a 3x3 tic-tac-toe
Parent: Bug 2039394 Games widget shell.
Diff Detail
Unit TestsBroken
Event TimelineDre planned changes to this revision.Fri, May 22, 7:42 PM Dre created this revision. phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Fri, May 22, 7:42 PM phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)". phab-bot removed a project: secure-revision. Dre requested review of this revision.Thu, May 28, 12:51 AM Dre updated this revision to Diff 1284931. Dre retitled this revision from WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers. Dre added a reviewer: home-newtab-reviewers-rotation. phab-bot removed reviewers: home-newtab-reviewers-rotation, reusable-components-reviewers-rotation. Dre planned changes to this revision.Thu, May 28, 12:54 AM Dre removed reviewers: accessibility-frontend-reviewers, reemhamz, akulyk. Dre planned changes to this revision.Thu, May 28, 1:50 AM Dre updated this revision to Diff 1284976. Dre retitled this revision from Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers. Dre requested review of this revision.Thu, May 28, 9:31 PM Dre updated this revision to Diff 1286073. Dre retitled this revision from WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers. Dre planned changes to this revision.Thu, May 28, 9:32 PM Dre retitled this revision from Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.Thu, Jun 4, 4:16 PM Dre removed reviewers: Restricted Project, desktop-theme-reviewers. Dre retitled this revision from Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers. Comment Actions This revision makes changes to files both inside and in files outside of it. The New Tab page for Firefox Desktop supports train-hopping — a mechanism that allows New Tab code to be deployed to Beta and Release channels independently of the standard release train. Cross-layer changes can break train-hop compatibility, which may block New Tab deployments until fixes reach Release through normal channels. If your change modifies platform code that browser/extensions/newtab depends on (such as module URIs, DOM APIs, or Nimbus feature definitions), please check whether a compatibility shim is needed. Shims should be marked with a comment indicating the Firefox version that must reach Release before the shim can be removed. If your change is unrelated to the New Tab page's train-hop compatibility (for example, it only touches tests or documentation), you can possibly disregard this message - but if you are unsure whether your change affects train-hop compatibility, please ensure that someone from the home-newtab-reviewers-rotation review group has a chance to review before landing. Dre planned changes to this revision.Tue, Jun 16, 8:25 PM Dre retitled this revision from WIP: Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers to Proof of concept, not for merging - Bug 2039394 - Add MozTacToe game r?#home-newtab-reviewers.Tue, Jun 16, 8:27 PM
Revision Contents
Diff 1301648 browser/extensions/newtab/content-src/components/Widgets/Games/titles/MozTacToe/MozTacToe.jsxLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/MozTacToe/_MozTacToe.scssLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/MozTacToe/moztactoe.mjsLoading... browser/extensions/newtab/content-src/components/Widgets/Games/titles/index.mjsLoading... browser/extensions/newtab/test/jest/content-src/components/Widgets/Games/MozTacToe.test.jsxLoading... |
